-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement currency locking and extend testing #158
Merged
neutrinoks
merged 3 commits into
feat/main-milestone-three
from
feat/multi-signer-currency-lock-and-tests
Mar 8, 2024
Merged
feat: implement currency locking and extend testing #158
neutrinoks
merged 3 commits into
feat/main-milestone-three
from
feat/multi-signer-currency-lock-and-tests
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neutrinoks
commented
Mar 7, 2024
•
edited
Loading
edited
- implemented currency locking in case of multi-signer execution requests
- extended existing unit tests for checking this implementation
- added a new unit test about checking the cheque limit in case of multi-signer requests
- fixed the GitHub CI action because otherwise, the checks wouldn't have been triggered in this PR
neutrinoks
force-pushed
the
feat/multi-signer-currency-lock-and-tests
branch
2 times, most recently
from
March 8, 2024 08:48
3ae859c
to
cafa764
Compare
neutrinoks
force-pushed
the
feat/multi-signer-currency-lock-and-tests
branch
from
March 8, 2024 09:00
cafa764
to
8682a08
Compare
Rqnsom
previously approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rqnsom
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.